Browse Source

[wallet] Fix leak in CDB constructor

Now using a std::unique_ptr, the Db instance is correctly released
when CDB initialization fails.
The internal CDB state and mapFileUseCount are only mutated when
the CDB initialization succeeds.

Github-Pull: #11492
Rebased-From: 7104de8b1f
tags/v0.15.1
João Barbosa 3 years ago
parent
commit
de7053f114
1 changed files with 16 additions and 18 deletions
  1. 16
    18
      src/wallet/db.cpp

+ 16
- 18
src/wallet/db.cpp View File

@@ -379,45 +379,43 @@ CDB::CDB(CWalletDBWrapper& dbw, const char* pszMode, bool fFlushOnCloseIn) : pdb
if (!env->Open(GetDataDir()))
throw std::runtime_error("CDB: Failed to open database environment.");

strFile = strFilename;
++env->mapFileUseCount[strFile];
pdb = env->mapDb[strFile];
pdb = env->mapDb[strFilename];
if (pdb == nullptr) {
int ret;
pdb = new Db(env->dbenv, 0);
std::unique_ptr<Db> pdb_temp(new Db(env->dbenv, 0));

bool fMockDb = env->IsMock();
if (fMockDb) {
DbMpoolFile* mpf = pdb->get_mpf();
DbMpoolFile* mpf = pdb_temp->get_mpf();
ret = mpf->set_flags(DB_MPOOL_NOFILE, 1);
if (ret != 0)
throw std::runtime_error(strprintf("CDB: Failed to configure for no temp file backing for database %s", strFile));
if (ret != 0) {
throw std::runtime_error(strprintf("CDB: Failed to configure for no temp file backing for database %s", strFilename));
}
}

ret = pdb->open(nullptr, // Txn pointer
fMockDb ? nullptr : strFile.c_str(), // Filename
fMockDb ? strFile.c_str() : "main", // Logical db name
DB_BTREE, // Database type
nFlags, // Flags
ret = pdb_temp->open(nullptr, // Txn pointer
fMockDb ? nullptr : strFilename.c_str(), // Filename
fMockDb ? strFilename.c_str() : "main", // Logical db name
DB_BTREE, // Database type
nFlags, // Flags
0);

if (ret != 0) {
delete pdb;
pdb = nullptr;
--env->mapFileUseCount[strFile];
strFile = "";
throw std::runtime_error(strprintf("CDB: Error %d, can't open database %s", ret, strFilename));
}

pdb = pdb_temp.release();
env->mapDb[strFilename] = pdb;

if (fCreate && !Exists(std::string("version"))) {
bool fTmp = fReadOnly;
fReadOnly = false;
WriteVersion(CLIENT_VERSION);
fReadOnly = fTmp;
}

env->mapDb[strFile] = pdb;
}
++env->mapFileUseCount[strFilename];
strFile = strFilename;
}
}


Loading…
Cancel
Save