Browse Source

Merge pull request #3662

0542619 Rename IsConfirmed to IsTrusted to better match the intended behavior. (Gregory Maxwell)
pull/1/head
Wladimir J. van der Laan 9 years ago
parent
commit
6056c87d25
No known key found for this signature in database
GPG Key ID: 74810B012346C9A6
  1. 2
      src/qt/transactionrecord.cpp
  2. 2
      src/rpcwallet.cpp
  3. 8
      src/wallet.cpp
  4. 2
      src/wallet.h

2
src/qt/transactionrecord.cpp

@ -164,7 +164,7 @@ void TransactionRecord::updateStatus(const CWalletTx &wtx) @@ -164,7 +164,7 @@ void TransactionRecord::updateStatus(const CWalletTx &wtx)
(wtx.IsCoinBase() ? 1 : 0),
wtx.nTimeReceived,
idx);
status.confirmed = wtx.IsConfirmed();
status.confirmed = wtx.IsTrusted();
status.depth = wtx.GetDepthInMainChain();
status.cur_num_blocks = chainActive.Height();

2
src/rpcwallet.cpp

@ -621,7 +621,7 @@ Value getbalance(const Array& params, bool fHelp) @@ -621,7 +621,7 @@ Value getbalance(const Array& params, bool fHelp)
for (map<uint256, CWalletTx>::iterator it = pwalletMain->mapWallet.begin(); it != pwalletMain->mapWallet.end(); ++it)
{
const CWalletTx& wtx = (*it).second;
if (!wtx.IsConfirmed())
if (!wtx.IsTrusted())
continue;
int64_t allFee;

8
src/wallet.cpp

@ -964,7 +964,7 @@ int64_t CWallet::GetBalance() const @@ -964,7 +964,7 @@ int64_t CWallet::GetBalance() const
for (map<uint256, CWalletTx>::const_iterator it = mapWallet.begin(); it != mapWallet.end(); ++it)
{
const CWalletTx* pcoin = &(*it).second;
if (pcoin->IsConfirmed())
if (pcoin->IsTrusted())
nTotal += pcoin->GetAvailableCredit();
}
}
@ -980,7 +980,7 @@ int64_t CWallet::GetUnconfirmedBalance() const @@ -980,7 +980,7 @@ int64_t CWallet::GetUnconfirmedBalance() const
for (map<uint256, CWalletTx>::const_iterator it = mapWallet.begin(); it != mapWallet.end(); ++it)
{
const CWalletTx* pcoin = &(*it).second;
if (!IsFinalTx(*pcoin) || !pcoin->IsConfirmed())
if (!IsFinalTx(*pcoin) || !pcoin->IsTrusted())
nTotal += pcoin->GetAvailableCredit();
}
}
@ -1015,7 +1015,7 @@ void CWallet::AvailableCoins(vector<COutput>& vCoins, bool fOnlyConfirmed, const @@ -1015,7 +1015,7 @@ void CWallet::AvailableCoins(vector<COutput>& vCoins, bool fOnlyConfirmed, const
if (!IsFinalTx(*pcoin))
continue;
if (fOnlyConfirmed && !pcoin->IsConfirmed())
if (fOnlyConfirmed && !pcoin->IsTrusted())
continue;
if (pcoin->IsCoinBase() && pcoin->GetBlocksToMaturity() > 0)
@ -1710,7 +1710,7 @@ std::map<CTxDestination, int64_t> CWallet::GetAddressBalances() @@ -1710,7 +1710,7 @@ std::map<CTxDestination, int64_t> CWallet::GetAddressBalances()
{
CWalletTx *pcoin = &walletEntry.second;
if (!IsFinalTx(*pcoin) || !pcoin->IsConfirmed())
if (!IsFinalTx(*pcoin) || !pcoin->IsTrusted())
continue;
if (pcoin->IsCoinBase() && pcoin->GetBlocksToMaturity() > 0)

2
src/wallet.h

@ -695,7 +695,7 @@ public: @@ -695,7 +695,7 @@ public:
return (GetDebit() > 0);
}
bool IsConfirmed() const
bool IsTrusted() const
{
// Quick answer in most cases
if (!IsFinalTx(*this))

Loading…
Cancel
Save