abrax
/
lizard
1
2
Fork 1
Code Issues 21 Pull Requests Releases Wiki Activity
Labels Milestones
New Issue

Validate DB schema in `check_database` #29

Open
opened 6 years ago by abrax · 0 comments
abrax commented 6 years ago
Owner

table_exists will only check if there's a table with that name, and returns true even if columns are wrong.

This is okay for now since I don't see how a table without the right columns could happen except if the user fucked with the DB manually, in which case he should know enough to fix it himself.

This will be a real problem if you ever change the schema in later versions. When that happens, use something like peewee-validates to validate the schema.

`table_exists` will only check if there's a table with that name, and returns true even if columns are wrong. This is okay for now since I don't see how a table without the right columns could happen except if the user fucked with the DB manually, in which case he should know enough to fix it himself. This will be a real problem if you ever change the schema in later versions. When that happens, use something like `peewee-validates` to validate the schema.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
Labels
Apply labels
Clear labels
bug feature-request feedback-needed improvement
No Label bug feature-request feedback-needed improvement
Milestone
Set milestone
Clear milestone
No items
No Milestone
0.4
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(MISSING)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes